Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support self hosted vcs #16

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Oct 8, 2023

Overview/Summary

Adding the ability to override SaaS hosted GitHub and Azure DevOps with a self-hosted VCS url.

NOTE: This is not something we can test and some features, such as Workload identity federation will not work with self hosted yet.

This PR fixes/adds/changes/removes

  1. Feature Request: Support self hosted VCS #13

Breaking Changes

None

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate added the enhancement New feature or request label Oct 8, 2023
Copy link
Contributor

@luke-taylor luke-taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments - just curious if there exists a combintion of input variables that would break the code i.e. self-hosted VCS trying to use federated credentials etc.

@jaredfholgate jaredfholgate merged commit 8e201cb into main Oct 10, 2023
@jaredfholgate jaredfholgate deleted the feature-support-self-hosted-vcs branch October 10, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants