Handle RD Infra Agent and Bootloader install strings containing spaces gracefully #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
murajput
commented
Mar 17, 2022
murajput
commented
- When the RDAgentBootLoader name contains a space in the title (exp. Microsoft.RDInfra.RDAgentBootLoader.Installer-x64 (7).msi), it causes the DSC Installation to hang in a transitioning phase as the msiexec command can't recognize the install.
- Encapsulated all /i $Path strings so they look like /i '$Path'.
dhrump
reviewed
Mar 17, 2022
| @@ -473,10 +473,10 @@ function InstallRDAgents { | |||
| } | |||
|
|
|||
| Write-Log -Message "Installing RD Infra Agent on VM $AgentInstaller" | |||
| RunMsiWithRetry -programDisplayName "RD Infra Agent" -argumentList @("/i $AgentInstaller", "/quiet", "/qn", "/norestart", "/passive", "REGISTRATIONTOKEN=$RegistrationToken") -msiOutputLogPath "C:\Users\AgentInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging | |||
| RunMsiWithRetry -programDisplayName "RD Infra Agent" -argumentList @("/i '$AgentInstaller'", "/quiet", "/qn", "/norestart", "/passive", "REGISTRATIONTOKEN=$RegistrationToken") -msiOutputLogPath "C:\Users\AgentInstall.txt" -msiLogVerboseOutput:$EnableVerboseMsiLogging | |||
There was a problem hiding this comment.
We should first do this change in portal repo and test it and put it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.