Load balance support #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Expect(allSettings.ConfigMapSettings["app:test:"]).Should(Equal("value6")) | ||
| }) | ||
|
|
||
| It("Succeed to get settings when load balance not enabled", func() { |
There was a problem hiding this comment.
Is the test necessary?
There was a problem hiding this comment.
Yes, test only single client used (line 1311) when load balance not enabled.
internal/loader/request_tracing.go
Outdated
Comment on lines
53
to
71
| if provider.Spec.ReplicaDiscoveryEnabled { | ||
| if manager, ok := clientManager.(*ConfigurationClientManager); ok { | ||
| replicaCount := 0 | ||
| if manager.DynamicClientWrappers != nil { | ||
| replicaCount = len(manager.DynamicClientWrappers) | ||
| } | ||
|
|
||
| output = append(output, fmt.Sprintf("ReplicaCount=%d", replicaCount)) | ||
|
|
||
| if manager.IsFailoverRequest { | ||
| output = append(output, "FailoverRequest") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if provider.Spec.LoadBalancingEnabled { | ||
| output = append(output, "UsesLoadBalancing") | ||
| } | ||
|
|
There was a problem hiding this comment.
Please align the format with .net provider
| if err != nil { | ||
| successful = false | ||
| updateClientBackoffStatus(clientWrapper, successful) | ||
| if IsFailoverable(err) { | ||
| klog.Warningf("current client of '%s' failed to get settings: %s", clientWrapper.Endpoint, err.Error()) | ||
| errors = append(errors, err) | ||
| if ok { |
There was a problem hiding this comment.
ok here just means it can find the RequestTracingEnabled in env var. I don't get the point here.
| @@ -37,6 +37,8 @@ import ( | |||
|
|
|||
| type ConfigurationClientManager struct { | |||
| ReplicaDiscoveryEnabled bool | |||
| LoadBalancingEnabled bool | |||
| IsFailoverRequest bool | |||
There was a problem hiding this comment.
I don't think it's required to be a property in ConfigurationClientManager, we don't need to remember the state of IsFailoverRequest
RichardChen820
approved these changes
Aug 26, 2024
linglingye001
added a commit
that referenced
this pull request
Nov 8, 2024
* load balance support * update load balance tracing * upgrade golangci version * update * skip cache for golangci lint * update * update * update envtest version * update envtest tool version * add cancel context * resolve comments * fix lint error * no need to update isFailoverRequest when succeed to get settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support load balance when
replicaDiscoveryEnabledAdd load balance and failover request tracing