update

Azure · Jul 19, 2024 · 030d112 · 030d112
1 parent 7fdc735
commit 030d112
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/internal/controller/appconfigurationprovider_controller.go b/internal/controller/appconfigurationprovider_controller.go
@@ -426,7 +426,7 @@ func (reconciler *AzureAppConfigurationProviderReconciler) createOrUpdateSecrets
 	}
 
 	for secretName, secret := range processor.Settings.SecretSettings {
-		if !shouldCreateOrUpdate(reconciler.ProvidersReconcileState[namespacedName].ExistingSecretReferences, secretName, processor.Settings.SecretReferences[secretName], processor.ShouldReconcile) {
+		if !shouldCreateOrUpdate(processor, secretName) {
 			if _, ok := reconciler.ProvidersReconcileState[namespacedName].ExistingSecretReferences[secretName]; ok {
 				processor.Settings.SecretReferences[secretName].SecretResourceVersion = reconciler.ProvidersReconcileState[namespacedName].ExistingSecretReferences[secretName].SecretResourceVersion
 			}

diff --git a/internal/controller/utils.go b/internal/controller/utils.go
@@ -303,15 +303,17 @@ func verifySelectorObject(selector acpv1.Selector) error {
 	return nil
 }
 
-func shouldCreateOrUpdate(existingSecretReferences map[string]*loader.TargetSecretReference, secretName string, secretReference *loader.TargetSecretReference, shouldReconcile bool) bool {
-	if shouldReconcile {
+func shouldCreateOrUpdate(processor *AppConfigurationProviderProcessor, secretName string) bool {
+	if processor.ShouldReconcile {
 		return true
 	}
 
+	existingSecretReferences := processor.ReconciliationState.ExistingSecretReferences
 	if _, ok := existingSecretReferences[secretName]; !ok {
 		return true
 	}
 
+	secretReference := processor.Settings.SecretReferences[secretName]
 	if len(existingSecretReferences[secretName].SecretMetadata) != len(secretReference.SecretMetadata) {
 		return true
 	}