Add an option to enable load balancing between replicas #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otnetProvider into ajusupovic/load-balancing
jimmyca15
reviewed
Apr 15, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs
Outdated
Show resolved
Hide resolved
…otnetProvider into ajusupovic/load-balancing
…AppConfiguration-DotnetProvider into ajusupovic/load-balancing
jimmyca15
reviewed
Apr 16, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Extensions/ListExtensions.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 16, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationOptions.cs
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 16, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/ConfigurationClientManager.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 16, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationSource.cs
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Apr 16, 2024
| @@ -990,6 +991,27 @@ private void UpdateNextRefreshTime(KeyValueWatcher changeWatcher) | |||
| Func<ConfigurationClient, Task<T>> funcToExecute, | |||
| CancellationToken cancellationToken = default) | |||
| { | |||
| if (_options.LoadBalancingEnabled && _lastSuccessfulEndpoint != null) | |||
There was a problem hiding this comment.
It seems to also make sense to check if there is more than one client in clients
jimmyca15
approved these changes
Apr 16, 2024
jimmyca15
approved these changes
Apr 17, 2024
|
Discussed offline, we can revert the last commit since we already depend on repeatable enumeration here. |
jimmyca15
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Azure/AppConfiguration#868
Adds the following new API to enable load-balancing of requests between replicas for an App Configuration store:
Load balancing will always operate on all endpoints available to the provider. If the
ReplicaDiscoveryEnabledproperty is set to true and endpoints have also been passed in explicitly like withAzureAppConfigurationOptions.Connect, then the provider will treat the passed-in endpoints as highest priority for sending requests. It will still load balance between passed-in endpoints and discovered replicas over time.