-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure upload of bcc installation logs #5258
Open
zachary-bailey
wants to merge
12
commits into
dev
Choose a base branch
from
zb/republishBccInstallationLogs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Artun Duman <[email protected]>
Co-authored-by: Lily Pan <[email protected]> Co-authored-by: r2k1 <[email protected]>
Co-authored-by: aks-node <[email protected]>
Co-authored-by: wenhug <[email protected]> Co-authored-by: Wen Huang <[email protected]>
Co-authored-by: wenhug <[email protected]> Co-authored-by: Wen Huang <[email protected]>
…rottling (#5233) Co-authored-by: Cameron Meissner <[email protected]> Co-authored-by: Cameron Meissner <[email protected]>
Co-authored-by: Cameron Meissner <[email protected]>
zachary-bailey
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
timmy-wright
as code owners
November 13, 2024 17:46
zachary-bailey
force-pushed
the
zb/republishBccInstallationLogs
branch
from
November 13, 2024 17:47
f58d482
to
b01d877
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/king bug
What this PR does / why we need it:
This PR appends a unique date time stamp to the bcc installation logs file before uploading it as an artifact in ADO.
Which issue(s) this PR fixes:
This ensures that the file will still upload when the re-run failed jobs feature in ADO is utilized.
Requirements: