Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce nyc weather features to feature-engineering on fabric single-tech sample #657

Merged

Conversation

thurstonchen
Copy link
Contributor

@thurstonchen thurstonchen commented Dec 8, 2023

Type of PR

  • Documentation changes
  • Code changes

Purpose

Introduce NYC weather dataset.

  • to make our model training scenario a bit closer to the practical use case :- )
  • switch to LightGBMRegressor model to have higher model performance metrics.
  • now we create two feature sets, nyctaxi and nycweather, the latter could be reused by other model training requirement, which is a good showcase on why we need feature store.

Besides introducing NYC weather data of year 2022, we also add Jan. 2023 taxi trip and weather data to do the batch inferencing.
Hi @promisinganuj, if you agree this PR, we'll share those new data files to you via Teams, thanks! :- )

Does this introduce a breaking change? If yes, details on what can break

NO

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • Put new NYC weather files to the public storage account.
  • Run the Fabric data pipeline again.
  • Run model training and inferencing notebooks, now the latter notebook also requires attaching the same lakehouse used by other notebooks.

Issues Closed or Referenced

N/A

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@promisinganuj
Copy link
Contributor

Hi @siliang-j-1225 as discussed, please review this PR in the next two weeks. I will be incorporating your review comments. Thanks for your help.

CC: @devlace

@promisinganuj promisinganuj added the single-tech: fabric Single-tech sample for Microsoft Fabric label Nov 1, 2024
@promisinganuj
Copy link
Contributor

HI @siliang-j-1225 , Hope you are well. Just checking whether you have bandwidth to look at it this week.

@siliang-j-1225
Copy link
Contributor

HI @siliang-j-1225 , Hope you are well. Just checking whether you have bandwidth to look at it this week.

Hey @promisinganuj, yes I will work on it this week.

@siliang-j-1225 siliang-j-1225 marked this pull request as ready for review November 13, 2024 03:29
@promisinganuj promisinganuj merged commit 1d2eff8 into main Nov 13, 2024
3 of 4 checks passed
@promisinganuj promisinganuj deleted the feat/single-tech/fe_on_fabric/introduce_nycweather_features branch November 13, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-tech: fabric Single-tech sample for Microsoft Fabric
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants