Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add EDA and data validation sections with other minor updates #655

Merged
merged 8 commits into from
Nov 22, 2023
Merged

doc: add EDA and data validation sections with other minor updates #655

merged 8 commits into from
Nov 22, 2023

Conversation

thurstonchen
Copy link
Contributor

@thurstonchen thurstonchen commented Nov 20, 2023 •
edited
Loading

Type of PR

  • Documentation changes

Purpose

Address below review comments for the V2 merge.

  • Added descriptions for each imported notebooks.
  • Added a section for the data validation notebook.
  • Added a section for the EDA notebook.
  • Added .gif files for Fabric 'Environment' setup section.
  • Removed not required .png screenshots.

Does this introduce a breaking change? If yes, details on what can break

NO

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

N/A

Issues Closed or Referenced

N/A

@promisinganuj
Copy link
Contributor

Hi @thurstonchen , @siliang-j-1225 , @cchenshu , great work. I have added few minor comments. Please have a look.

promisinganuj
promisinganuj approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, well done!

@promisinganuj promisinganuj marked this pull request as ready for review November 21, 2023 21:22
@thurstonchen thurstonchen merged commit 5a9b9d9 into main Nov 22, 2023
3 of 4 checks passed
@devlace devlace deleted the doc/single-tech/feature_engineering_on_fabric branch December 11, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promisinganuj promisinganuj promisinganuj approved these changes

@cchenshu cchenshu Awaiting requested review from cchenshu

@siliang-j-1225 siliang-j-1225 Awaiting requested review from siliang-j-1225

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thurstonchen @promisinganuj