[E2E Databricks] - Sprint 4 changes #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#988) * automate region vm + dbx type cluster in the region * Update e2e_samples/parking_sensors/scripts/configure_databricks.sh Co-authored-by: Elena Terenzi <[email protected]> * filtering photon support --------- Co-authored-by: Elena Terenzi <[email protected]>
* fix breaking change from dbx cli output * fix hyperlink check
Adding the Cleanup for federal credentials which follows a certain order: Get the SP Objc ID of the Service Connection Delete federated credentials from the SP Object ID Delete the service connection
Service Connections are using the Workload Identity which comes from a configuration file. The cleanup in case of re-start of this script also follows a peculiar order: Get SP object if according to the Service Connection Get the federate credential according to the SP Delete federated credentials Delete the Service Connection
changing the docs with the required permission
rephrase the permissions needed for azdevops project
Co-authored-by: Yennifer Santos <[email protected]>
…tions_azure.sh Co-authored-by: Yennifer Santos <[email protected]>
I adjust the order of the permissions
adding know issues how to delete federate credentials
identation was not correct
adding the following changes: 1) Function for cleanup 2)Function for sleep 3)Remove log file
Implement function for cleanup and function for sleep
Added cleanup_federate_credentials and wait_for_credentials used in the clean_up.sh and deploy_azdo_service_connection.sh
rename wait_for_cleanup to wait_for_process
renamed wait_for_cleanup to wait_for_process
typo: comtain to contain fxed
added Elena's suggestion of rewrite Co-authored-by: Elena Terenzi <[email protected]>
remove the log for SP
Clean up of the log suppress update pipelines message remove response from logging
changing the log for federate credentials removal
adding the SP in the log message
checking if the file exist before removal.
Co-authored-by: Elena Terenzi <[email protected]>
Co-authored-by: Elena Terenzi <[email protected]>
Co-authored-by: Elena Terenzi <[email protected]>
…tions_azure.sh Co-authored-by: Elena Terenzi <[email protected]>
…tions_azure.sh Co-authored-by: Elena Terenzi <[email protected]>
Co-authored-by: Elena Terenzi <[email protected]>
Co-authored-by: Elena Terenzi <[email protected]>
Co-authored-by: Elena Terenzi <[email protected]>
role unecessary
adding -0 none to resolve conflict
…parkingsensor_v1_lilem
…sor_v1_lilem E2e/databricks/parkingsensor v1 lilem
Fix dashboard bicep Warnings #955
ydaponte
added
bug
…val (#1047) * remove federated credentials only when needed * fix typo
elenaterenzi
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose
Does this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist
Validation steps
Issues Closed or Referenced