[Databricks E2E] [BUG]: Clean Up should Delete App Registration #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenaterenzi
changed the base branch from
main
to
e2e/databricks/parking-sensors-V1
elenaterenzi
changed the title
elenaterenzi
merged commit 442cf6e
into
e2e/databricks/parking-sensors-V1
3 checks passed
ydaponte
added a commit
that referenced
this pull request
Jan 21, 2025
* [E2E Databricks] - Automate region vm + dbx type cluster in the region (#988) * automate region vm + dbx type cluster in the region * Update e2e_samples/parking_sensors/scripts/configure_databricks.sh Co-authored-by: Elena Terenzi <[email protected]> * filtering photon support --------- Co-authored-by: Elena Terenzi <[email protected]> * [Databricks E2E Sample] - bug fix dbx compute (#1006) * fix breaking change from dbx cli output * fix hyperlink check * Cluster config update (#1012) * Update clean_up.sh Adding the Cleanup for federal credentials which follows a certain order: Get the SP Objc ID of the Service Connection Delete federated credentials from the SP Object ID Delete the service connection * Update deploy_azdo_service_connections_azure.sh Service Connections are using the Workload Identity which comes from a configuration file. The cleanup in case of re-start of this script also follows a peculiar order: Get SP object if according to the Service Connection Get the federate credential according to the SP Delete federated credentials Delete the Service Connection * Update README.md changing the docs with the required permission * Update README.md rephrase the permissions needed for azdevops project * Update e2e_samples/parking_sensors/scripts/clean_up.sh Co-authored-by: Yennifer Santos <[email protected]> * Update e2e_samples/parking_sensors/scripts/deploy_azdo_service_connections_azure.sh Co-authored-by: Yennifer Santos <[email protected]> * Update README.md I adjust the order of the permissions * Update README.md adding know issues how to delete federate credentials * Update README.md identation was not correct * Fix The property "options" Warnings in Dashboard.bicep * Update deploy_azdo_service_connections_azure.sh adding the following changes: 1) Function for cleanup 2)Function for sleep 3)Remove log file * Update clean_up.sh Implement function for cleanup and function for sleep * Update common.sh Added cleanup_federate_credentials and wait_for_credentials used in the clean_up.sh and deploy_azdo_service_connection.sh * Update clean_up.sh rename wait_for_cleanup to wait_for_process * Update deploy_azdo_service_connections_azure.sh renamed wait_for_cleanup to wait_for_process * Fix typo in clean_up.sh log message typo: comtain to contain fxed * Update e2e_samples/parking_sensors/README.md added Elena's suggestion of rewrite Co-authored-by: Elena Terenzi <[email protected]> * Update common.sh remove the log for SP * Update deploy_azdo_service_connections_azure.sh Clean up of the log suppress update pipelines message remove response from logging * Update common.sh changing the log for federate credentials removal * Update common.sh adding the SP in the log message * Update deploy_azdo_service_connections_azure.sh checking if the file exist before removal. * Update e2e_samples/parking_sensors/scripts/common.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/common.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/common.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/deploy_azdo_service_connections_azure.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/deploy_azdo_service_connections_azure.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/clean_up.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/common.sh Co-authored-by: Elena Terenzi <[email protected]> * Update e2e_samples/parking_sensors/scripts/common.sh Co-authored-by: Elena Terenzi <[email protected]> * Remove unnesissary dependsOn in main.bicep * Remove redundant comment and variable role unecessary * Checking if I can solve the conflicts * conflict * conflict * The new file after tryto solve the conflict * Trying again to solve the conflict * Suppress output for service connection deletion adding -0 none to resolve conflict * add code to delete app registrations (#1019) * [Databricks E2E] [BUG] cleanup fix bug with federated credential removal (#1047) * remove federated credentials only when needed * fix typo --------- Co-authored-by: Elena Terenzi <[email protected]> Co-authored-by: Ayman El-Ghazali <[email protected]> Co-authored-by: LiliamLeme <[email protected]> Co-authored-by: Raafat Zarka <[email protected]> Co-authored-by: Liliam Leme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Purpose
clean_up.shdoes not delete app registrations, but only enterprise apps. This PR adds code to deal with app registration removalDoes this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist
Validation steps
Issues Closed or Referenced