Update Program.cs #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original program.cs returned the following error:
NotFound error occurred: Microsoft.Azure.Cosmos.CosmosException : Response status code does not indicate success: 404 Substatus: 0 Reason: ({
"Errors": [
"Resource Not Found"
]
}).
StatusCode = NotFound;
SubStatusCode = 0;
|
|
ealsur
reviewed
Feb 11, 2020
| Console.WriteLine("Item in database with id: {0} already exists\n", andersenFamilyResponse.Resource.Id); | ||
| } | ||
| // Upsert the item, i.e. if it exists it gets updated, otherwise it gets created | ||
| ItemResponse<Family> andersenFamilyResponse = await this.container.UpsertItemAsync<Family>(andersenFamily, new PartitionKey(andersenFamily.LastName)); |
There was a problem hiding this comment.
I believe this beats the purpose of the original code, while I agree that Upsert solves the exception, the code was showing how to handle a scenario where an item might Not exist.
Possible try/catch CosmosException when StatusCode == NotFound
There was a problem hiding this comment.
@ealsur Thanks for the feedback. I added try catch semantics to the code. Keep in mind that the method Container.ReadItemAsync returns an exception when the code runs. Therefore, since the Cosmos Database and its container are empty the catch block will always execute and the items will get created in each catch clause.
ealsur
suggested changes
Feb 11, 2020
Since the Method Container.ReadItemAsync<T> will throw an exception "Resource Not Found (404)" I added try-catch semantics to catch it and act accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original program.cs returned the following error:
NotFound error occurred: Microsoft.Azure.Cosmos.CosmosException : Response status code does not indicate success: 404 Substatus: 0 Reason: ({
"Errors": [
"Resource Not Found"
]
}).
StatusCode = NotFound;
SubStatusCode = 0;
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information