Skip to content

Commit

Permalink
fix: Use new docker syntax for ENV (#1465)
Browse files Browse the repository at this point in the history
  • Loading branch information
ross-p-smith authored Nov 6, 2024
1 parent 607e891 commit 43a2a4f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions docker/Admin.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ RUN pip install --upgrade pip && pip install poetry && poetry export -o requirem
COPY ./code/backend /usr/local/src/myscripts/admin
COPY ./code/backend/batch/utilities /usr/local/src/myscripts/utilities
WORKDIR /usr/local/src/myscripts/admin
ENV PYTHONPATH "${PYTHONPATH}:/usr/local/src/myscripts/"
# https://github.com/docker/buildx/issues/2751
ENV PYTHONPATH="${PYTHONPATH}:/usr/local/src/myscripts/"

Check warning on line 11 in docker/Admin.Dockerfile

View workflow job for this annotation

GitHub Actions / docker-build (rag-adminwebapp, docker/Admin.Dockerfile) / docker-build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$PYTHONPATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 11 in docker/Admin.Dockerfile

View workflow job for this annotation

GitHub Actions / docker-build (rag-adminwebapp, docker/Admin.Dockerfile) / docker-build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$PYTHONPATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
EXPOSE 80
CMD ["streamlit", "run", "Admin.py", "--server.port", "80", "--server.enableXsrfProtection", "false"]
CMD ["streamlit", "run", "Admin.py", "--server.port", "80", "--server.enableXsrfProtection", "false"]
3 changes: 2 additions & 1 deletion docker/Frontend.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ RUN pip install --upgrade pip && pip install poetry uwsgi && poetry export -o re
COPY ./code/*.py /usr/src/app/
COPY ./code/backend /usr/src/app/backend
COPY --from=frontend /home/node/app/dist/static /usr/src/app/static/
ENV PYTHONPATH "${PYTHONPATH}:/usr/src/app"
# https://github.com/docker/buildx/issues/2751
ENV PYTHONPATH="${PYTHONPATH}:/usr/src/app"

Check warning on line 23 in docker/Frontend.Dockerfile

View workflow job for this annotation

GitHub Actions / docker-build (rag-webapp, docker/Frontend.Dockerfile) / docker-build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$PYTHONPATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

Check warning on line 23 in docker/Frontend.Dockerfile

View workflow job for this annotation

GitHub Actions / docker-build (rag-webapp, docker/Frontend.Dockerfile) / docker-build

Variables should be defined before their use

UndefinedVar: Usage of undefined variable '$PYTHONPATH' More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/
EXPOSE 80
CMD ["uwsgi", "--http", ":80", "--wsgi-file", "app.py", "--callable", "app", "-b", "32768", "--http-timeout", "230"]

0 comments on commit 43a2a4f

Please sign in to comment.