Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra buffer time between each deployment steps #544

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jiamguo
Copy link
Contributor

@jiamguo jiamguo commented Mar 11, 2021

Purpose

  • Add 1 min buffer time between each deployment steps to allow backend propagate.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

Other Information

@jiamguo jiamguo requested a review from a team as a code owner March 11, 2021 19:59
@jiamguo jiamguo requested a review from dargilco March 15, 2021 18:46
@@ -97,16 +97,25 @@ Write-Host -ForegroundColor Yellow "Calling deployTemplate"
Write-Host -ForegroundColor Yellow "$command"
Invoke-Expression $command

# some buffer time between each step
Start-Sleep -s 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to add such a long sleep, please print an appropriate message before the sleep so users do not think there is some sort of a hang in the script.
But in general, this is odd, as I run this script multiple times and did not need this. Isn't 60 seconds way too long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Only kept sleep period after creating container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants