add docs for offline #539
Open
add docs for offline #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovishesh
suggested changes
Feb 11, 2021
|
|
||
| ### The host computer | ||
|
|
||
| The host is an x-64 or arm-64 based computer that runs the Docker container. |
There was a problem hiding this comment.
could we add information about recommended space, memory and compute?
There was a problem hiding this comment.
Just noticed it below. If we could structure all the pre-reqs together that will be awesome!
|
|
||
| ## Download Custom Commands container image with docker pull | ||
|
|
||
| Since, offline Custom Commands is an experimental feature, currently, you will only be able to consume it based on explicit approval. Please reach out to our team, and we can help you onboard. |
There was a problem hiding this comment.
I would recommend to move this sentence to the top of this document as a note
mswellsi
reviewed
Feb 11, 2021
| @@ -0,0 +1,123 @@ | |||
| # Running the Custom Command Embedded Service on Windows | |||
There was a problem hiding this comment.
The title says Windows. In the body of the document it includes other OS including macos and Linux. Is the document meant to cover all of them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Sharing changes for visibility. I still need to update the image name for the service here.
Add initial documentation for service side changes for Offline Custom Commands
Does this introduce a breaking change?
Pull Request Type
Add document
How to Test
N/A: Docs changes
N/A: Docs changes
What to Check
N/A: Docs changes
Other Information