chore(avm): Remove initialization for non-derived polynomials #10103
+32
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
requested review from
IlyasRidhuan,
fcarreiro and
Maddiaa0
as code owners
fcarreiro
reviewed
Nov 21, 2024
jeanmon
force-pushed
the
jm/10096-uninitialize-non-derivative-polys
branch
from
409b0c2
to
34878d6
Compare
|
Some benchmarks on the "parallel_for" code portion inside of "circuit_builder/init_polys_unshifted". On mainframe, without any hardcoded set for HARDWARE_CONCURRENCY env variable: 4 measurements: PR | MASTER HARDWARE_CONCURRENCY = 4 3 measurements: PR | MASTER |
fcarreiro
approved these changes
Nov 22, 2024
| @@ -284,6 +284,14 @@ template <typename Fr> class Polynomial { | |||
| return p; | |||
| } | |||
|
|
|||
| /** | |||
| * @brief A factory to construct a polynomial where parallel initialization is | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10096