feat!: add AztecAddress.isValid and make random be valid #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs PreviewHey there! 👋 You can check your preview at https://6740916de90097ac0fb1a18a--aztec-docs-dev.netlify.app |
yarn-project/foundation/src/aztec-address/aztec-address.test.ts
Outdated
Show resolved
Hide resolved
|
I refactored |
iAmMichaelConnor
approved these changes
Nov 22, 2024
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10039
Since #8970 is not yet implemented, invalid addresses cannot be the recipient of e.g. token transfers, since we end up producing points not in the curve and causing MSM to fail. Making
random()return valid addresses seems like very reasonable behavior.