Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flamegraph script (and enable > 1 circuit) #10065

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

iAmMichaelConnor
Copy link
Contributor

The flamegraph script was broken.
Then I added some extra features:

  • The ability to specify >1 circuit name.
  • -l list the names of all the available, compiled circuits, because I can't be bothered typing them.
  • -a create flamegraphs for all the circuits at once.
  • -n don't try to create flamegraphs, just act as a proxy to the server and serve me my flamegraphs.

Look at them all muhahahahahaha:
image


/// The output name for the flamegraph svg files
#[clap(long, short = 'f', default_value = "main")]
output_filename: String
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this rust is acceptable, but I needed each flamegraph to have a distinct name, rather than overwriting main_gates.svg repeatedly.

@iAmMichaelConnor
Copy link
Contributor Author

Ohh, @sirasistant does CI get angry if I try to touch Noir in here instead of in the Noir repo?

@sirasistant
Copy link
Contributor

It's just formatting errors: you need to run cargo fmt :D

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Changes to circuit sizes

Generated at commit: 7acf8e98656cbf7579b69208c002c789b07821bc, compared to commit: a2c070161d8466c6da61f68b4d97107927f45129

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private +137,564 ❌ +69.59% +750,997 ❌ +28.25%
rollup_base_public +25,379 ❌ +5.68% -251,515 ✅ -6.29%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 335,237 (+137,564) +69.59% 3,409,576 (+750,997) +28.25%
rollup_base_public 472,504 (+25,379) +5.68% 3,745,928 (-251,515) -6.29%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants