-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flamegraph script (and enable > 1 circuit) #10065
base: master
Are you sure you want to change the base?
Conversation
|
||
/// The output name for the flamegraph svg files | ||
#[clap(long, short = 'f', default_value = "main")] | ||
output_filename: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this rust is acceptable, but I needed each flamegraph to have a distinct name, rather than overwriting main_gates.svg
repeatedly.
Ohh, @sirasistant does CI get angry if I try to touch Noir in here instead of in the Noir repo? |
It's just formatting errors: you need to run cargo fmt :D |
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
The flamegraph script was broken.
Then I added some extra features:
-l
list the names of all the available, compiled circuits, because I can't be bothered typing them.-a
create flamegraphs for all the circuits at once.-n
don't try to create flamegraphs, just act as a proxy to the server and serve me my flamegraphs.Look at them all muhahahahahaha: