Merge pull request #39 from Ayc0/Ayc0/no-listening

Drop listening **BREAKING CHANGE**
Ayc0 · Jul 30, 2023 · 71b4438 · 71b4438
2 parents 063a6dc + d56466e
commit 71b4438
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/packages/manatea/README.md b/packages/manatea/README.md
@@ -185,17 +185,6 @@ const waiter = cup.on(console.log);
 waiter();
 ```
 
-At any moment, you can check if a waiter is running by checking its `listening` attribute:
-
-```js
-const waiter = cup.on(console.log);
-
-waiter.listening; // true
-
-waiter();
-waiter.listening; // false
-```
-
 ### Derived cup
 
 You can create a cup based on another one, or multiple other ones:

diff --git a/packages/manatea/__tests__/manatea.ts b/packages/manatea/__tests__/manatea.ts
@@ -27,9 +27,7 @@ describe('Manatea', () => {
  const cup = orderCup<number>(1);
  const fn = jest.fn();
  const waiter = cup.on(fn);
- expect(waiter.listening).toBe(true);
  waiter();
- expect(waiter.listening).toBe(false);
  await cup(2);
  expect(fn).not.toHaveBeenCalled();
  });

diff --git a/packages/manatea/src/index.ts b/packages/manatea/src/index.ts
@@ -17,7 +17,6 @@ type Handler<FlavoredTea extends Tea> = (
 ) => void;
 export interface Waiter {
  (): boolean;
- listening: boolean;
 }
 
 type Order<FlavoredTea extends Tea, UnflavoredTea extends Tea> =
@@ -101,9 +100,6 @@ export function orderCup<
  cup.on = (fn: Handler<FlavoredTea>) => {
  handlers.add(fn);
  const waiter = () => handlers.delete(fn);
- Object.defineProperty(waiter, 'listening', {
- get: () => handlers.has(fn),
- });
  return waiter as Waiter;
  };