Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEEDS #12] Refactor dependency version checking logic #13

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

[NEEDS #12] Refactor dependency version checking logic #13

wants to merge 45 commits into from

Commits on Sep 6, 2017

  1. Update variable names in tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    090605e View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary variable assignments

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    dfa7314 View commit details
    Browse the repository at this point in the history

  3. Replace Windows-incompatible random string generation method

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5289005 View commit details
    Browse the repository at this point in the history

  4. Bypass SSL validation in clone tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    a5e228c View commit details
    Browse the repository at this point in the history

  5. Finish 'Apply clean' spec

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    cca19d1 View commit details
    Browse the repository at this point in the history

  6. Finish 'Apply smudge' spec

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5228532 View commit details
    Browse the repository at this point in the history

  7. Refactor 'Amend Check/Smudge' tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b608209 View commit details
    Browse the repository at this point in the history

  8. Refactor out test constants

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5aa57ad View commit details
    Browse the repository at this point in the history

  9. Finish check callback tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    82c4cac View commit details
    Browse the repository at this point in the history

  10. Finish initialize callback tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    bb7482a View commit details
    Browse the repository at this point in the history

  11. Finish execHelper tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    582544f View commit details
    Browse the repository at this point in the history

  12. Bump sinon to 3.2.1

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    f1f8ba0 View commit details
    Browse the repository at this point in the history

  13. Stop swallowing Promise rejections in specs 

    For a more complete description: http://eng.wealthfront.com/2016/11/03/handling-unhandledrejections-in-node-and-the-browser/
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    4c099e5 View commit details
    Browse the repository at this point in the history

  14. Finish spawnHelper tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    9a333dd View commit details
    Browse the repository at this point in the history

  15. Finish helper tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    3dba914 View commit details
    Browse the repository at this point in the history

  16. Add object rest spread Babel plugin and fix devDependencies issue 

    On CI, `devDependencies` won't be installed, but Babel is required to `compile`, etc.
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    eb68183 View commit details
    Browse the repository at this point in the history

  17. Don't redefine NodeGitLFS in tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    afd6154 View commit details
    Browse the repository at this point in the history

  18. Finish unregister tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    0cd12af View commit details
    Browse the repository at this point in the history

  19. Remove unnecessary regexResult helper

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    9a7ed04 View commit details
    Browse the repository at this point in the history

  20. Add tests for project-wide helpers

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    e0fcf43 View commit details
    Browse the repository at this point in the history

  21. Finish 'clone' tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    e501cad View commit details
    Browse the repository at this point in the history

  22. Remove trailing commas

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5285d8d View commit details
    Browse the repository at this point in the history

  23. Add machinery to simulate a remote locally

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    068f206 View commit details
    Browse the repository at this point in the history

  24. Require nodegit 0.20.1 

    Tests rely on NodeGit calling the LFS filters when necessary, so we need to be using a version of NodeGit that supports this machinery in the first place.
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    fea3c93 View commit details
    Browse the repository at this point in the history

  25. Automatically register and unregister the LFS filters before and afte… 

    …r each test
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    3d0da1b View commit details
    Browse the repository at this point in the history

  26. Fix clone specs to use new simulated remote machinery

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    7338e57 View commit details
    Browse the repository at this point in the history

  27. Remove trailing commas (post-rebase)

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    5ed34e5 View commit details
    Browse the repository at this point in the history

  28. Remove unnecessary variable assignments (post-rebase)

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    2652ae1 View commit details
    Browse the repository at this point in the history

  29. Allow spawnHelper to have the created process' env overwritten

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    d375041 View commit details
    Browse the repository at this point in the history

  30. The spawn helper should reject if a non-0 exit code is returned

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b7d61ce View commit details
    Browse the repository at this point in the history

  31. Use pre-defined *RepoPath constants in tests

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    bb30f6f View commit details
    Browse the repository at this point in the history

  32. Fix segfaults and such (and broken tests)

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    178fb61 View commit details
    Browse the repository at this point in the history

  33. Add spec stubs [WIP]

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    68e9f11 View commit details
    Browse the repository at this point in the history

  34. Standardize test style 

    Fix tests post-rebase
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    465d6e4 View commit details
    Browse the repository at this point in the history

  35. Standardize error-handling logic

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    b89bdd0 View commit details
    Browse the repository at this point in the history

  36. Kill LFS test server on unhandled Promise rejection in specs

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    db59e7a View commit details
    Browse the repository at this point in the history

  37. Adjust for rebase-caused changes

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    f132bd7 View commit details
    Browse the repository at this point in the history

  38. Remove unnecessary branchName option from the pull command 

    `git-lfs-pull`'s manpage says "Download all Git LFS files for current ref & checkout", and I don't see any options to pull a specific branch's files.
My guess is that this code was copy-and-pasted from the `fetch` command, explaining the extraneous argument.

Also, this commit has test stubs for the `fetch` and `pull` commands.
    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    8a70b3d View commit details
    Browse the repository at this point in the history

  39. Add errorCatchHandler spec stubs

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    8152101 View commit details
    Browse the repository at this point in the history

  40. Update spec stubs (post-rebase)

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    1aff4e5 View commit details
    Browse the repository at this point in the history

  41. Remove unnecessary nodegit imports

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    deedc94 View commit details
    Browse the repository at this point in the history

  42. Fix spawnHelper tests (post-rebase)

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    2536e2b View commit details
    Browse the repository at this point in the history

  43. Refactor version-checking logic

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    1a0174a View commit details
    Browse the repository at this point in the history

  44. Use semver for dependency version comparisons

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    ac01ece View commit details
    Browse the repository at this point in the history

  45. Add specs

    Joshua Grosso authored and Joshua Grosso committed Sep 6, 2017
    Configuration menu
    Copy the full SHA
    abd2961 View commit details
    Browse the repository at this point in the history