Fix spawnHelper tests (post-rebase)

Axosoft · Sep 6, 2017 · 6bffea9 · 6bffea9
1 parent d1e1bcf
commit 6bffea9
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 13 deletions.
diff --git a/src/commands/checkout.js b/src/commands/checkout.js
@@ -74,7 +74,7 @@ function checkout(repo, callback) {
       }
 
       return response;
-    }, errorCatchHandler(response));
+    }, errorCatchHandler);
 }
 
 export default checkout;
diff --git a/src/constants.js b/src/constants.js
@@ -13,13 +13,13 @@ export const regex = {
   USERNAME: /username/g,
   PASSWORD: /password/g,
   PASSPHRASE: /passphrase/g,
-  PERMISSION_DENIED: /permission\s+denied\s+\(.+\)\./g,
+  PERMISSION_DENIED: /permission\s+denied\s+\(.+\)\./g
 };
 
 export const promptTypes = {
   USERNAME: 'username',
   PASSWORD: 'password',
-  PASSPHRASE: 'passphrase',
+  PASSPHRASE: 'passphrase'
 };
 
 export const BAD_VERSION = '0';

diff --git a/src/helpers.js b/src/helpers.js
@@ -3,10 +3,10 @@ import path from 'path';
 import R from 'ramda';
 
 import {
-  LFS_ATTRIBUTE,
   BAD_CORE_RESPONSE,
   BAD_REGEX_PARSE_RESULT,
-  regex,
+  LFS_ATTRIBUTE,
+  regex
 } from './constants';
 import generateResponse from './utils/generateResponse';
 

diff --git a/src/utils/spawnHelper.js b/src/utils/spawnHelper.js
@@ -31,11 +31,11 @@ const buildSocketPath = () => tmp.dir()
  *   (
  *     spawnedProcess: ChildProcess,
  *     callback: (
- *       passwordOnly: boolean,
- *       callback: (usernamePrompt: boolean) =>
+ *       output: string,
+ *       callback: (promptType: string) =>
  *                 (username: string, password: ?string, cancel: boolean) =>
  *                 void
- *       )
+ *       ) => void
  *     ),
  *     reject: Error => Promise<void>
  *   ) =>
@@ -220,7 +220,7 @@ const spawn = (command, opts = {}, callback) => new Promise(
 
       resolve({
         code,
-        stdout,
+        stdout
       });
     });
   });

diff --git a/test/tests/utils/spawnHelper.spec.js b/test/tests/utils/spawnHelper.spec.js
@@ -58,8 +58,6 @@ describe('spawnHelper', () => {
     it('resolves with the correct data on a successful exit', todo);
 
     it('rejects on spawn error', todo);
-
-    it('rejects on non-0 exit code', todo);
   });
 
   describe('winSpawn', () => {
@@ -111,8 +109,6 @@ describe('spawnHelper', () => {
   describe('buildSocket', () => {
     it('resolves the calling `Promise` with the correct data on a successful exit', todo);
 
-    it('only runs the successful close logic once', todo);
-
     it('calls the close callback when the socket ends', todo);
 
     it('calls the close callback when the socket closes', todo);