Skip to content

Commit

Permalink
Fix spawnHelper tests (post-rebase)
Browse files Browse the repository at this point in the history
  • Loading branch information
Joshua Grosso committed Sep 5, 2017
1 parent d1e1bcf commit 09fa557
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
8 changes: 4 additions & 4 deletions src/utils/spawnHelper.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ const buildSocketPath = () => tmp.dir()
* (
* spawnedProcess: ChildProcess,
* callback: (
* passwordOnly: boolean,
* callback: (usernamePrompt: boolean) =>
* output: string,
* callback: (promptType: string) =>
* (username: string, password: ?string, cancel: boolean) =>
* void
* )
* ) => void
* ),
* reject: Error => Promise<void>
* ) =>
Expand Down Expand Up @@ -220,7 +220,7 @@ const spawn = (command, opts = {}, callback) => new Promise(

resolve({
code,
stdout,
stdout
});
});
});
Expand Down
4 changes: 0 additions & 4 deletions test/tests/utils/spawnHelper.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ describe('spawnHelper', () => {
it('resolves with the correct data on a successful exit', todo);

it('rejects on spawn error', todo);

it('rejects on non-0 exit code', todo);
});

describe('winSpawn', () => {
Expand Down Expand Up @@ -111,8 +109,6 @@ describe('spawnHelper', () => {
describe('buildSocket', () => {
it('resolves the calling `Promise` with the correct data on a successful exit', todo);

it('only runs the successful close logic once', todo);

it('calls the close callback when the socket ends', todo);

it('calls the close callback when the socket closes', todo);
Expand Down

0 comments on commit 09fa557

Please sign in to comment.