Skip to content

Commit

Permalink
Document current state
Browse files Browse the repository at this point in the history
  • Loading branch information
Axionize committed Nov 25, 2024
1 parent 30bfbc8 commit 22b0dcb
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ public CollisionBox fetchRegularBox(GrimPlayer player, WrappedBlockState state,
return new SimpleCollisionBox(f, 0.0F, f2, f1, 1, f3);
}

/*
This implementation together with the simulation engine ave some limitations.
Running into/being knocked into corner walls on a legacy server on a modern client and vice versa
Lead to simulation falses. Fixing this rare edge case requires lots more effort than worth and is low priority
*/
@Override
public CollisionBox fetch(GrimPlayer player, ClientVersion version, WrappedBlockState block, int x, int y, int z) {
boolean isNewClient = version.isNewerThan(ClientVersion.V_1_12_2);
Expand Down

0 comments on commit 22b0dcb

Please sign in to comment.