This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Check if m3u8 contains audio stream before use #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you actually test this fix in quantity and did this solve the issue for you, every time? |
|
It did work for my cases, but unfortunately there are not many videos without audio, just a few, so the quantity is not high. |
|
I was creating a similar one as well. I confirm this fixes the same issues as I encountered |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi fellows.
When using I had issues with some m3u8 videos without audio, failing to download the video and crashing the script.
I just added a quick check if there is an audio stream before accessing it.
I hope it help anybody with the same issue 👍