Skip to content

Commit

Permalink
drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_ld_…
Browse files Browse the repository at this point in the history
…modes

commit 66edf3fb331b6c55439b10f9862987b0916b3726 upstream.

In nv17_tv_get_ld_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a possible NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.

Cc: [email protected]
Signed-off-by: Ma Ke <[email protected]>
Signed-off-by: Lyude Paul <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Ma Ke authored and Avenger-285714 committed Jul 5, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 7c33bee commit be90d9e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
Original file line number Diff line number Diff line change
@@ -209,6 +209,8 @@ static int nv17_tv_get_ld_modes(struct drm_encoder *encoder,
struct drm_display_mode *mode;

mode = drm_mode_duplicate(encoder->dev, tv_mode);
if (!mode)
continue;

mode->clock = tv_norm->tv_enc_mode.vrefresh *
mode->htotal / 1000 *

0 comments on commit be90d9e

Please sign in to comment.