Fix crashing after opening a uri on browser #17524
Merged
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Return the
boolean
result directly instead an windowJSObject
inWindowOpen
, otherwise some properties of theJSObject
may be accessed while the object being collected by the GC, and failed due to a security error, which will terminate the whole process:This is also more performant as we no longer need to marshal the
JSObject
.What is the current behavior?
The whole process crash after opening a uri and the returned JSObject being collected by the GC.
What is the updated/expected behavior with this PR?
No longer crash.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues