Call CaptureLost on gestures when pointer loses capture #12666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmauss
force-pushed
the
gesture_cancel
branch
from
92ae557
to
caaee5f
Compare
|
cool. This should also unblock #12558 now. |
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Aug 26, 2023
| @@ -61,6 +62,7 @@ protected override void PointerPressed(PointerPressedEventArgs e) | |||
| { | |||
| if (Target != null && Target is Visual visual && (e.Pointer.Type == PointerType.Touch || e.Pointer.Type == PointerType.Pen)) | |||
| { | |||
| Debug.WriteLine($"Pointer with ID: {e.Pointer.Id} pressed"); | |||
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
gesture_cancel
branch
from
c0cd98c
to
f81b454
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Aug 29, 2023
3 tasks
emmauss
added
the
backport-candidate-11.0.x
grokys
pushed a commit
that referenced
this pull request
Oct 2, 2023
Call CaptureLost on gestures when pointer loses capture
grokys
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Ensures that the pointer capture lost event is called on all gesture recognizers attached to an input element.
What is the current behavior?
All gestures receive the PointerPressed event, and they set states to start tracking the pointer. If PointerMoveD is received and the conditions for the gesture is met, the gesture captures the pointer, and no other gesture receives events. When the pointer is released, all gestures receive the Released events and reset their states.
In the case of Touch, if the device sends a TouchCancel event, it's interpreted as a CaptureLost event. Only the captured InputElement and the CapturedGesture handles this. For other gestures on the input element that have received the PointerPressed event and set their initial state, they don't receive any event to reset it. This is also true when none of the gestures have captured the pointer
What is the updated/expected behavior with this PR?
When an input element loses pointer capture, all gesture recognizers attached to it that was not the source of the CaptureLost gets
notified. When the pointer loses capture or is cancelled, all gesture recognizers of the last caputed element will be notified.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #12083