Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler: Fix the action bar stuck #83452

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Oct 25, 2023

Related to #83034

Proposed Changes

  • The action bar might be stuck there when you hover off the pattern. The reason is the device-switcher__frame element is removed & appended to the DOM whenever the value of the hasSelectedPattern changes. And it leads to the mouseleave event on the device-switcher__frame element cannot be triggered anymore.
  • Here is the real case on production (chrome only) but I cannot reproduce it on my local env
    • When you land on the Assembler with the selected pattern at the beginning (e.g.: refresh the page), the hasSelectedPattern is false initially, and we bind the mouseleave event to the device-switcher__frame element. However, the value becomes true immediately so the mouseleave event doesn't work as that element will be removed from the DOM and then appended again.

Testing Instructions

  • Go to the Assembler
  • Select a pattern, remove it, and select it again
  • Hover on that pattern and ensure you see the action bar
  • Hover off that pattern and ensure the action bar will be gone instead of sticking there

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@arthur791004 arthur791004 self-assigned this Oct 25, 2023
@github-actions
Copy link

github-actions bot commented Oct 25, 2023

@matticbot
Copy link
Contributor

matticbot commented Oct 25, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~21 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
import-flow        +43 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 requested a review from a team October 25, 2023 06:01
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 25, 2023
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arthur791004 arthur791004 merged commit 4d1bc0f into trunk Oct 25, 2023
12 checks passed
@arthur791004 arthur791004 deleted the fix/assembler-action-bar-stuck branch October 25, 2023 07:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants