Fix manual capture status source #9708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
timur27
force-pushed
the
fix/manual-capture-status
branch
from
d4578ab
to
957a1b9
Compare
timur27
requested review from
a team and
danielmx-dev
and removed request for
a team
danielmx-dev
approved these changes
Nov 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9551
Changes proposed in this Pull Request
The manual capture feature flag was removed some time ago, and the code no longer relies on this flag. This PR updates the WooPayments settings class to retrieve the manual capture status from the same option used by other classes.
Testing instructions
Confirm that
Issue an authorization on checkout, and capture latercheckbox is checked,WooCommerce->StatusshowsAuth and CaptureasEnabledDisabledwith unchecked checkboxnpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge