Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update phpcompatibility to develop version to get sniffs for PHP 8 #9697

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
+60 −18
Open

Update phpcompatibility to develop version to get sniffs for PHP 8 #9697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bbcc3ab
Update phpcompatibility to develop version to get sniffs for PHP 8.x,…
alopezari Nov 11, 2024
4c9143a
Add changelog.
alopezari Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/update-phpcompatibility-latest
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: dev
Comment: Update phpcompatibility to develop version to get sniffs for PHP 8. No need to include it in the changelog since it is a dev task that doesn't impact WooPayments.


3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
"woocommerce/qit-cli": "0.4.0",
"slevomat/coding-standard": "8.15.0",
"dg/bypass-finals": "1.5.1",
"sirbrillig/phpcs-variable-analysis": "^2.11"
"sirbrillig/phpcs-variable-analysis": "^2.11",
"phpcompatibility/php-compatibility": "dev-develop as 9.3.5"
},
"scripts": {
"test": [
Expand Down
68 changes: 52 additions & 16 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

<!-- Configs -->
<config name="minimum_supported_wp_version" value="6.0" />
<config name="testVersion" value="7.3-" />
<config name="testVersion" value="7.3-7.4" />

<!-- Rules -->
<rule ref="WooCommerce-Core" >
Expand Down
Loading