Check that cart total is not zero before rendering express checkout #9691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvrtx
requested review from
a team and
gpressutto5
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +21 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
…o-amount-after-coupon-discount
…o-amount-after-coupon-discount
…o-amount-after-coupon-discount
…o-amount-after-coupon-discount
gpressutto5
approved these changes
Nov 13, 2024
…o-amount-after-coupon-discount
…o-amount-after-coupon-discount
dmvrtx
deleted the
fix/9687-express-checkout-visible-for-zero-amount-after-coupon-discount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9687
Changes proposed in this Pull Request
I've discovered a few other similar code flows, but those appear to be not affected by the case of coupons, as there is nowhere to enter the coupon code, e.g. on the product page.
Testing instructions
On a separate note, if we reapply coupon, we will get an error notice "Coupon has already been applied!", but the cart update will happen as it should.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge