Support payment activity widget fetching & displaying differnt deposit currencies #8864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +8 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
jessy-p
reviewed
Jun 3, 2024
includes/core/server/request/class-get-reporting-payment-activity.md
Outdated
Show resolved
Hide resolved
jessy-p
reviewed
Jun 3, 2024
includes/core/server/request/class-get-reporting-payment-activity.md
Outdated
Show resolved
Hide resolved
|
Thanks for diving into my unfinished PR @jessy-p 🙌 You're welcome to take over this PR and/or the server side PR, or restart in a clean PR – whatever works best for you. Let me know how I can assist with a clean handover – I'm keen to get myself out of the critical path for the project. These two PRs were me exploring how close we are to showing different deposit currency in payment widget – and I can see that we're pretty close 👌 |
added 3 commits
June 4, 2024 15:30
…://github.com/Automattic/woocommerce-payments into add/deposit-currency-param-for-payment-widget
jessy-p
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8865
Part of epic #8490
Changes proposed
The goal of this PR is to implement whatever is needed to allow the payment widget to show different deposit currencies. Should be possible to hard-code different currencies and the widget should show the relevant data (for stores that have multiple deposit currencies).
Testing instructions
Change the currencies in the code and test.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge