-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for adapted extensions in Direct Checkout #8849
Add support for adapted extensions in Direct Checkout #8849
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +179 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Code changes look good and test well.
Testing Instructions
- 🟢 2692-gh-Automattic/woopay test instructions.
- 🟢
npm run test:js
andnpm run test:php
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress!
There were just a few more things we may need to handle before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Code changes look good and test well
Testing Instructions
- 🟢 2692-gh-Automattic/woopay test instructions.
- 🟢
npm run test:js
andnpm run test:php
.
Closes https://github.com/Automattic/woopay/issues/2648.
Changes proposed in this Pull Request
Testing instructions
This should be tested alongside with https://github.com/Automattic/woopay/pull/2692, which contains all testing instructions needed.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge