Fix QIT errors reported by PHPStan

changelog/fix-phpstan-errors

@@ -0,0 +1,4 @@
+Significance: minor
+Type: dev
+
+Fix PHPStan warnings.

includes/class-wc-payments-account.php

@@ -1675,7 +1675,7 @@ function () {
 	 *
 	 * @return void
 	 */
-	public function update_cached_account_data( $property, $data ) {
+	public function update_account_data( $property, $data ) {
 		$account_data = $this->database_cache->get( Database_Cache::ACCOUNT_KEY );
 
 		$account_data[ $property ] = is_array( $data ) ? array_merge( $account_data[ $property ] ?? [], $data ) : $data;
@@ -1692,16 +1692,6 @@ public function refresh_account_data() {
 		return $this->get_cached_account_data( true );
 	}
 
-	/**
-	 * Updates the account data.
-	 *
-	 * @param string $property Property to update.
-	 * @param mixed  $data     Data to update.
-	 */
-	public function update_account_data( $property, $data ) {
-		return $this->update_cached_account_data( $property, $data );
-	}
-
 	/**
 	 * Checks if the cached account can be used in the current plugin state.
 	 *

includes/class-wc-payments-payment-request-button-handler.php

@@ -408,7 +408,7 @@ public function get_product_price( $product, ?bool $is_deposit = null, int $depo
 		}
 
 		// If WooCommerce Deposits is active, we need to get the correct price for the product.
-		if ( class_exists( 'WC_Deposits_Product_Manager' ) && WC_Deposits_Product_Manager::deposits_enabled( $product->get_id() ) ) {
+		if ( class_exists( 'WC_Deposits_Product_Manager' ) && class_exists( 'WC_Deposits_Plans_Manager' ) && WC_Deposits_Product_Manager::deposits_enabled( $product->get_id() ) ) {
 			// If is_deposit is null, we use the default deposit type for the product.
 			if ( is_null( $is_deposit ) ) {
 				$is_deposit = 'deposit' === WC_Deposits_Product_Manager::get_deposit_selected_type( $product->get_id() );

includes/class-wc-payments.php

@@ -1437,37 +1437,37 @@ public static function add_woo_admin_notes() {
 		}
 
 		if ( defined( 'WC_VERSION' ) && version_compare( WC_VERSION, '7.5', '<' ) && get_woocommerce_currency() === 'NOK' ) {
-			/**
-			 * Shows an alert notice for Norwegian merchants on WooCommerce 7.4 and below
-			 */
-			function wcpay_show_old_woocommerce_for_norway_notice() {
-				?>
-				<div class="notice wcpay-notice notice-error">
-					<p>
-					<?php
-					echo WC_Payments_Utils::esc_interpolated_html( // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
-						sprintf(
-							/* translators: %1$s: WooCommerce, %2$s: WooPayments, a1: documentation URL */
-							__( 'The %1$s version you have installed is not compatible with %2$s for a Norwegian business. Please update %1$s to version 7.5 or above. You can do that via the <a1>the plugins page.</a1>', 'woocommerce-payments' ),
-							'WooCommerce',
-							'WooPayments'
-						),
-						[
-							'a1' => '<a href="' . esc_url( admin_url( 'plugins.php' ) ) . '">',
-						]
-					)
-					?>
-					</p>
-				</div>
-				<?php
-			}
-
-			add_filter( 'admin_notices', 'wcpay_show_old_woocommerce_for_norway_notice' );
+			add_filter( 'admin_notices', [ __CLASS__, 'wcpay_show_old_woocommerce_for_norway_notice' ] );
 		}
 
 		add_filter( 'admin_notices', [ __CLASS__, 'wcpay_show_old_woocommerce_for_hungary_sweden_and_czech_republic' ] );
 	}
 
+	/**
+	 * Shows an alert notice for Norwegian merchants on WooCommerce 7.4 and below
+	 */
+	public static function wcpay_show_old_woocommerce_for_norway_notice() {
+		?>
+		<div class="notice wcpay-notice notice-error">
+			<p>
+			<?php
+			echo WC_Payments_Utils::esc_interpolated_html( // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
+				sprintf(
+					/* translators: %1$s: WooCommerce, %2$s: WooPayments, a1: documentation URL */
+					__( 'The %1$s version you have installed is not compatible with %2$s for a Norwegian business. Please update %1$s to version 7.5 or above. You can do that via the <a1>the plugins page.</a1>', 'woocommerce-payments' ),
+					'WooCommerce',
+					'WooPayments'
+				),
+				[
+					'a1' => '<a href="' . esc_url( admin_url( 'plugins.php' ) ) . '">',
+				]
+			)
+			?>
+			</p>
+		</div>
+		<?php
+	}
+
 	/**
 	 * Removes WCPay notes from the WC-Admin inbox.
 	 */

includes/compat/blocks/class-blocks-data-extractor.php

@@ -45,6 +45,7 @@ private function get_available_blocks() {
 			// phpcs:ignore
 			/**
 			 * @psalm-suppress UndefinedClass
+			 * @phpstan-ignore-next-line
 			 */
 			$blocks[] = new \Automatewoo\Blocks\Marketing_Optin_Block();
 		}
@@ -53,6 +54,7 @@ private function get_available_blocks() {
 			// phpcs:ignore
 			/**
 			 * @psalm-suppress UndefinedClass
+			 * @phpstan-ignore-next-line
 			 */
 			$blocks[] = new \Mailchimp_Woocommerce_Newsletter_Blocks_Integration();
 		}
@@ -96,11 +98,13 @@ private function get_mailpoet_data() {
 		 * We check whether relevant MailPoet classes exists before invoking this method.
 		 *
 		 * @psalm-suppress UndefinedClass
+		 * @phpstan-ignore-next-line
 		 */
 		$mailpoet_wc_subscription = \MailPoet\DI\ContainerWrapper::getInstance()->get( \MailPoet\WooCommerce\Subscription::class );
 		// phpcs:ignore
 		/**
 		 * @psalm-suppress UndefinedClass
+		 * @phpstan-ignore-next-line
 		 */
 		$settings_instance = \MailPoet\Settings\SettingsController::getInstance();
 		$settings          = [

includes/compat/subscriptions/class-wc-payments-email-failed-authentication-retry.php

@@ -9,6 +9,8 @@
  * @package WooCommerce\Payments
  */
 
+use WCPay\Logger;
+
 if ( ! defined( 'ABSPATH' ) ) {
 	exit;
 }
@@ -18,6 +20,13 @@
  */
 class WC_Payments_Email_Failed_Authentication_Retry extends WC_Email_Failed_Order {
 
+	/**
+	 * The details of the last retry (if any) recorded for a given order
+	 *
+	 * @var WCS_Retry
+	 */
+	private $retry;
+
 	/**
 	 * Constructor
 	 */
@@ -71,7 +80,7 @@ public function trigger( $order_id, $order = null ) {
 			$this->retry                 = WCS_Retry_Manager::store()->get_last_retry_for_order( wcs_get_objects_property( $order, 'id' ) );
 			$this->replace['retry-time'] = wcs_get_human_time_diff( $this->retry->get_time() );
 		} else {
-			WC_Stripe_Logger::log( 'WCS_Retry_Manager class or does not exist. Not able to send admin email about customer notification for authentication required for renewal payment.' );
+			Logger::log( 'WCS_Retry_Manager class or does not exist. Not able to send admin email about customer notification for authentication required for renewal payment.' );
 			return;
 		}
 

includes/compat/subscriptions/trait-wc-payment-gateway-wcpay-subscriptions.php

@@ -103,6 +103,14 @@ abstract protected function prepare_payment_information( $order );
 	 */
 	private static $has_attached_integration_hooks = false;
 
+	/**
+	 * Used to temporary keep the state of the order_pay value on the Pay for order page with the SCA authorization flow.
+	 * For more details, see remove_order_pay_var and restore_order_pay_var hooks.
+	 *
+	 * @var string|int
+	 */
+	private $order_pay_var;
+
 	/**
 	 * Initialize subscription support and hooks.
 	 */
@@ -941,7 +949,9 @@ public function get_mandate_params_for_order( WC_Order $order ): array {
 		if ( 1 < count( $subscriptions ) ) {
 			$result['card']['mandate_options']['amount_type'] = 'maximum';
 			$result['card']['mandate_options']['interval']    = 'sporadic';
-			unset( $result['card']['mandate_options']['interval_count'] );
+			if ( isset( $result['card']['mandate_options']['interval_count'] ) ) {
+				unset( $result['card']['mandate_options']['interval_count'] );
+			}
 		}
 
 		return $result;

includes/constants/class-base-constant.php

@@ -98,6 +98,8 @@ public static function search( string $value ) {
 	 */
 	public static function __callStatic( $name, $arguments ) {
 		if ( ! isset( static::$object_cache[ $name ] ) ) {
+			// Instantiating constants by class name using the 'new static($name)' approach is integral to this method's functionality.
+			// @phpstan-ignore-next-line.
 			static::$object_cache[ $name ] = new static( $name );
 		}
 		return static::$object_cache[ $name ];

includes/express-checkout/class-wc-payments-express-checkout-button-helper.php

@@ -750,7 +750,7 @@ public function get_product_price( $product, ?bool $is_deposit = null, int $depo
 		}
 
 		// If WooCommerce Deposits is active, we need to get the correct price for the product.
-		if ( class_exists( 'WC_Deposits_Product_Manager' ) && WC_Deposits_Product_Manager::deposits_enabled( $product->get_id() ) ) {
+		if ( class_exists( 'WC_Deposits_Product_Manager' ) && class_exists( 'WC_Deposits_Plans_Manager' ) && WC_Deposits_Product_Manager::deposits_enabled( $product->get_id() ) ) {
 			if ( is_null( $is_deposit ) ) {
 				/**
 				 * If is_deposit is null, we use the default deposit type for the product.

includes/multi-currency/Compatibility/WooCommerceNameYourPrice.php

@@ -63,7 +63,7 @@ public function add_initial_currency( $cart_item, $product_id, $variation_id ) {
 
 		$nyp_id = $variation_id ? $variation_id : $product_id;
 
-		if ( \WC_Name_Your_Price_Helpers::is_nyp( $nyp_id ) && isset( $cart_item['nyp'] ) ) {
+		if ( class_exists( '\WC_Name_Your_Price_Helpers' ) && \WC_Name_Your_Price_Helpers::is_nyp( $nyp_id ) && isset( $cart_item['nyp'] ) ) {
 			$currency                  = $this->multi_currency->get_selected_currency();
 			$cart_item['nyp_currency'] = $currency->get_code();
 			$cart_item['nyp_original'] = $cart_item['nyp'];
@@ -102,6 +102,7 @@ public function convert_cart_currency( $cart_item, $values ) {
 				$cart_item['nyp'] = $this->multi_currency->get_raw_conversion( $raw_price, $selected_currency->get_code(), $from_currency );
 			}
 
+			// @phpstan-ignore-next-line.
 			$cart_item = WC_Name_Your_Price()->cart->set_cart_item( $cart_item );
 		}
 
@@ -130,7 +131,7 @@ public function should_convert_product_price( bool $return, $product ): bool {
 		}
 
 		// Check to see if the product is a NYP product.
-		if ( \WC_Name_Your_Price_Helpers::is_nyp( $product ) ) {
+		if ( class_exists( '\WC_Name_Your_Price_Helpers' ) && \WC_Name_Your_Price_Helpers::is_nyp( $product ) ) {
 			return false;
 		}
 

includes/multi-currency/Compatibility/WooCommerceProductAddOns.php

@@ -125,8 +125,10 @@ public function get_item_data( $addon_data, $addon, $cart_item ): array {
 				// Quantity/multiplier add on needs to be split, calculated, then multiplied by input value.
 				$price = $this->multi_currency->get_price( $addon['price'] / $addon['value'], 'product' ) * $addon['value'];
 			}
-			$price = \WC_Product_Addons_Helper::get_product_addon_price_for_display( $price, $cart_item['data'] );
-			$name .= ' (' . wc_price( $price ) . ')';
+			if ( class_exists( '\WC_Product_Addons_Helper' ) ) {
+				$price = \WC_Product_Addons_Helper::get_product_addon_price_for_display( $price, $cart_item['data'] );
+				$name .= ' (' . wc_price( $price ) . ')';
+			}
 		} else {
 			// Get the percentage cost in the currency in use, and set the meta data on the product that the value was converted.
 			$_product = wc_get_product( $cart_item['product_id'] );
@@ -245,12 +247,14 @@ public function order_line_item_meta( array $meta_data, array $addon, \WC_Order_
 				// Convert all others.
 				$addon_price = $this->multi_currency->get_price( $addon['price'], 'product' );
 			}
-			$price          = html_entity_decode(
-				wp_strip_all_tags( wc_price( \WC_Product_Addons_Helper::get_product_addon_price_for_display( $addon_price, $values['data'] ) ) ),
-				ENT_QUOTES,
-				get_bloginfo( 'charset' )
-			);
-			$addon['name'] .= ' (' . $price . ')';
+			if ( class_exists( '\WC_Product_Addons_Helper' ) ) {
+				$price          = html_entity_decode(
+					wp_strip_all_tags( wc_price( \WC_Product_Addons_Helper::get_product_addon_price_for_display( $addon_price, $values['data'] ) ) ),
+					ENT_QUOTES,
+					get_bloginfo( 'charset' )
+				);
+				$addon['name'] .= ' (' . $price . ')';
+			}
 		}
 
 		if ( 'custom_price' === $addon['field_type'] ) {

includes/woopay/class-woopay-adapted-extensions.php

@@ -171,7 +171,7 @@ public function get_extension_data() {
 			];
 		}
 
-		if ( $this->is_affiliate_for_woocommerce_enabled() ) {
+		if ( $this->is_affiliate_for_woocommerce_enabled() && function_exists( 'afwc_get_referrer_id' ) ) {
 			/**
 			 * Suppress psalm warning.
 			 *
@@ -207,12 +207,14 @@ public function update_order_extension_data( $order_id ) {
 		) {
 			$affiliate_id = (int) wc_clean( wp_unslash( $_GET['affiliate'] ) ); // phpcs:ignore WordPress.Security.NonceVerification
 
-			// phpcs:ignore
-			/**
-			 * @psalm-suppress UndefinedClass
-			 */
-			$affiliate_api = \AFWC_API::get_instance();
-			$affiliate_api->track_conversion( $order_id, $affiliate_id, '', [ 'is_affiliate_eligible' => true ] );
+			if ( class_exists( '\AFWC_API' ) ) {
+				// phpcs:ignore
+				/**
+				 * @psalm-suppress UndefinedClass
+				 */
+				$affiliate_api = \AFWC_API::get_instance();
+				$affiliate_api->track_conversion( $order_id, $affiliate_id, '', [ 'is_affiliate_eligible' => true ] );
+			}
 		}
 	}
 
@@ -272,7 +274,10 @@ class_exists( '\AutomateWoo\Referrals\Referral_Manager' ) &&
 	 * @return string|null
 	 */
 	private function get_automate_woo_advocate_id_from_cookie() {
-		$advocate_from_key_cookie = \AutomateWoo\Referrals\Referral_Manager::get_advocate_key_from_cookie();
-		return $advocate_from_key_cookie ? $advocate_from_key_cookie->get_advocate_id() : null;
+		if ( class_exists( '\AutomateWoo\Referrals\Referral_Manager' ) ) {
+			$advocate_from_key_cookie = \AutomateWoo\Referrals\Referral_Manager::get_advocate_key_from_cookie();
+			return $advocate_from_key_cookie ? $advocate_from_key_cookie->get_advocate_id() : null;
+		}
+		return null;
 	}
 }

includes/woopay/class-woopay-store-api-token.php

@@ -55,6 +55,7 @@ public function get_args() {
 		 * @psalm-suppress UndefinedMethod
 		 */
 		public function get_cart_token() {
+			// @phpstan-ignore-next-line.
 			return parent::get_cart_token();
 		}
 	}

src/Internal/Payment/State/AbstractPaymentState.php

@@ -79,6 +79,7 @@ public function get_context(): PaymentContext {
 	 * @throws PaymentRequestException   When data is not available or invalid.
 	 */
 	public function start_processing( PaymentRequest $request ) {
+		// @phpstan-ignore-next-line
 		$this->throw_unavailable_method_exception( __METHOD__ );
 	}
 
@@ -92,6 +93,7 @@ public function start_processing( PaymentRequest $request ) {
 	 * @throws StateTransitionException
 	 */
 	public function complete_processing() {
+		// @phpstan-ignore-next-line
 		$this->throw_unavailable_method_exception( __METHOD__ );
 	}
 	// phpcs:enable Squiz.Commenting.FunctionComment.InvalidNoReturn
@@ -103,15 +105,15 @@ public function complete_processing() {
 	 * This method should only be called whenever the process is ready to transition
 	 * to the next state, as each new state will be considered the payment's latest one.
 	 *
-	 * @template ConcreteState
-	 * @param class-string<ConcreteState> | string $state_class The class of the state to crate.
+	 * @template ConcreteState of AbstractPaymentState
+	 * @param class-string<ConcreteState> $state_class The class of the state to create.
 	 *
-	 * @return AbstractPaymentState | ConcreteState
+	 * @return ConcreteState The generated payment state instance.
 	 *
 	 * @throws StateTransitionException In case the new state could not be created.
 	 * @throws ContainerException       When the dependency container cannot instantiate the state.
 	 */
-	protected function create_state( string $state_class ) {
+	protected function create_state( /*class-string<ConcreteState>*/ $state_class ): AbstractPaymentState {
 		$state = $this->state_factory->create_state( $state_class, $this->context );
 
 		// This is where logging will be added.

src/Internal/Payment/State/StateFactory.php

@@ -38,15 +38,15 @@ public function __construct( Container $container ) {
 	/**
 	 * Creates a new state based on class name.
 	 *
-	 * @template ConcreteState
-	 * @param class-string<ConcreteState> | string $state_class Name of the state class.
-	 * @param PaymentContext                       $context     Context for the new state.
+	 * @template ConcreteState of AbstractPaymentState
+	 * @param class-string<ConcreteState> $state_class Name of the state class.
+	 * @param PaymentContext              $context     Context for the new state.
 	 *
-	 * @return AbstractPaymentState | ConcreteState                        The generated payment state instance.
+	 * @return ConcreteState                        The generated payment state instance.
 	 * @throws ContainerException         When the dependency container cannot instantiate the state.
 	 * @throws StateTransitionException   When the class name is not a state.
 	 */
-	public function create_state( string $state_class, PaymentContext $context ): AbstractPaymentState {
+	public function create_state( /*class-string<ConcreteState>*/ $state_class, PaymentContext $context ): AbstractPaymentState {
 		if ( ! is_subclass_of( $state_class, AbstractPaymentState::class ) ) {
 			throw new StateTransitionException(
 				esc_html(