Added support to Cartes Bancaires #8568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +74 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
gpressutto5
requested review from
a team and
timur27
and removed request for
a team
timur27
reviewed
Apr 5, 2024
There was a problem hiding this comment.
The code looks good, I have a couple questions to the feature behavior and ACs:
- Looking at the Stripe charge object [example], I'm seeing
"network": "visa"although the ACs of Enable card brand choice #8062 expect"network": "cartes_bancaires". Do you happen to know if it's us who need introduce more changes, or ACs need to change? - You mentioned that the transactions list does not show CB. I see in order details doesn't show CB either but Visa credit card instead [example]. Is this also something to handle in a separate issue/PR?
- Enable card brand choice #8062 mentions
the card should default to the brand selected by the merchant. Do you know if this expectation is still valid and if yes, how can merchant select the default brand?
|
auto-merge was automatically disabled
April 5, 2024 15:19
Pull request was converted to draft
11 tasks
|
@timur27 3. is potentially being removed from the AC list #8062 (comment), so I'm request another review. |
timur27
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
@gpressutto5 understood about removing 3) from the ACs, can confirm that Cartes Bancaires appears in the charge object as well as in the order details. 👍
I assume that eftpos Australia co-branded cards don't need to be covered or will be covered separately?
Other than the above question, we're good to merge. 🚢
Jinksi
pushed a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8062
Changes proposed in this Pull Request
When these cards are used in Stores that do not support this branch, they default to Visa or Mastercard, otherwise, Stripe renders a dropdown with the brands.
To support CB, we nee you need to use EUR and use a French account. Other countries in the EEA require processing 50 EUR LIVE before Cartes Bancaires is enabled. Any country not part of the EEA does not support Cartes Bancaires, so the brands dropdown is never rendered.
Testing instructions
Known error:
The transactions list does not show CB, it will only render Visa or Mastercard. I'm working on a fix for that from the server and it will not require another PR for the client.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge