➕ ADDS: is_managed key while setting up credentials for Parse.ly Inte…

…gration
Automattic · Aug 21, 2023 · 2bd16ca · 2bd16ca
1 parent cf0f5e1
commit 2bd16ca
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/integrations/parsely.php b/integrations/parsely.php
@@ -48,6 +48,7 @@ public function wp_parsely_credentials_callback( $original_credentials ) {
  }
 
  return array(
+ 'is_managed' => true,
  'site_id' => $config['site_id'] ?? null,
  'api_secret' => $config['api_secret'] ?? null,
  );

diff --git a/tests/integrations/test-parsely.php b/tests/integrations/test-parsely.php
@@ -9,7 +9,6 @@
 
 use WP_UnitTestCase;
 
-use function Automattic\Test\Utils\get_class_method_as_public;
 use function Automattic\Test\Utils\get_class_property_as_public;
 use function Automattic\Test\Utils\is_parsely_disabled;
 use function Automattic\VIP\WP_Parsely_Integration\maybe_load_plugin;
@@ -37,18 +36,27 @@ public function test__load_call_is_defining_the_enabled_constant_and_adding_filt
  $this->assertFalse( has_filter( 'wp_parsely_credentials' ) );
  }
 
- public function test__wp_parsely_credentials_callback_returns_original_credentials_of_the_integration(): void {
+ public function test__wp_parsely_credentials_callback_returns_original_credentials_of_the_integration_if_config_does_not_exist(): void {
+ $parsely_integration = new ParselyIntegration( $this->slug );
+ get_class_property_as_public( Integration::class, 'options' )->setValue( $parsely_integration, [] );
+
+ $callback_value = $parsely_integration->wp_parsely_credentials_callback( false );
+
+ $this->assertEquals( false, $callback_value );
+ }
+
+ public function test__wp_parsely_credentials_callback_returns_original_credentials_of_the_integration_if_config_is_empty(): void {
  $parsely_integration = new ParselyIntegration( $this->slug );
  get_class_property_as_public( Integration::class, 'options' )->setValue( $parsely_integration, [
  'config' => [],
  ] );
 
- $callback_value = get_class_method_as_public( ParselyIntegration::class, 'wp_parsely_credentials_callback' )->invoke( $parsely_integration, [ 'original' ] );
+ $callback_value = $parsely_integration->wp_parsely_credentials_callback( [ 'original' ] );
 
  $this->assertEquals( [ 'original' ], $callback_value );
  }
 
- public function test__wp_parsely_credentials_callback_returns_platform_credentials_of_the_integration(): void {
+ public function test__wp_parsely_credentials_callback_returns_platform_credentials_of_the_integration_if_config_exists(): void {
  $parsely_integration = new ParselyIntegration( $this->slug );
  get_class_property_as_public( Integration::class, 'options' )->setValue( $parsely_integration, [
  'config' => [
@@ -57,9 +65,10 @@ public function test__wp_parsely_credentials_callback_returns_platform_credentia
  ],
  ] );
 
- $callback_value = get_class_method_as_public( ParselyIntegration::class, 'wp_parsely_credentials_callback' )->invoke( $parsely_integration, array() );
+ $callback_value = $parsely_integration->wp_parsely_credentials_callback( array() );
 
  $this->assertEquals( [
+ 'is_managed' => true,
  'site_id' => 'value',
  'api_secret' => null,
  ], $callback_value );