Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urbem: add theme #8424

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Urbem: add theme #8424

merged 3 commits into from
Nov 18, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Nov 18, 2024

Urbem is a spin-off of Vitrum, a theme with wide-width layouts, generous space for images, and bold type sizes.

Demo site

screenshot

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Preview changes

I've detected changes to the following themes in this PR: Urbem.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@henriqueiamarino henriqueiamarino added the Ready to launch Add this label if this is the first PR for a new theme label Nov 18, 2024
@henriqueiamarino
Copy link
Collaborator Author

@iamtakashi, I renamed Downtown and submitted it again, as the theme name has already been taken. I can't explain that happening again. I am pretty sure I checked it in Belgrad, right next to you, and there were no theme names like it. Anyway, they do exist, and I will have to rename them; I am sorry.

I already added Downtown to this list to be delisted in the future. Let me know if I can do more to fix that issue.

@iamtakashi
Copy link
Contributor

iamtakashi commented Nov 18, 2024

Sorry that happened to you again :( But don't worry, Downtown has yet to launch on Dotcom, so it doesn't have to be on the list, and once I review this quickly, we can launch it as Urbem on both Dotorg and Dotcom.

@iamtakashi
Copy link
Contributor

Let's use a capitalised name in the style.css and the readme.txt So the name will appear nicely here.
CleanShot 2024-11-18 at 12 06 50@2x
CleanShot 2024-11-18 at 12 02 58@2x
CleanShot 2024-11-18 at 12 03 06@2x

For the theme description in the style.css, I think you meant Vitrum rather than Vetro.

Other than those, it looks good to ship!

Copy link
Contributor

Theme-Check results

urbem: No changes required ✅.


@henriqueiamarino henriqueiamarino merged commit 303e9f3 into trunk Nov 18, 2024
3 checks passed
@henriqueiamarino henriqueiamarino deleted the add/urbem branch November 18, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants