Add body class for theme variations #7432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
donnapep
approved these changes
Oct 20, 2023
|
Hi @donnapep 👋 As per our discussion here Automattic/sensei#7225, I've moved the functionality here. It gives us the added advantage of not having to check which theme is in use. Also, I've added a hook which can be used from sensei or any other place to enqueue variation specific stylesheets. I've also added stylesheets for each variation. Once we have this PR approved, we can close the associated PR in Sensei because we won't need that anymore. Also, we can share our approach in the theme team's issue. Thanks! |
donnapep
reviewed
Oct 31, 2023
donnapep
approved these changes
Oct 31, 2023
donnapep
changed the title
renatho
pushed a commit
that referenced
this pull request
Nov 1, 2023
* Update styles of question feedback (#7373) * Specify the grade style to be applied only in the question header * Update background color for gold variation * Update background color for default variation * Update border color for gold variation * Tweak CSS formatting * Tweak color for border of ordering question --------- Co-authored-by: Donna Peplinskie <[email protected]> * Update version and description * Add new changelog * Remove legacy Learning Mode CSS as it's part of Sensei now (#7431) * Course: Add body class for theme variations (#7432) * Add custom property with variation name * Add function to add body class and enqueue proper stylesheets * Add stylesheets for all variations * Add version number * Style the "Awaiting Grade" notice (#7401) * Style "Awaiting Grade" notice * Move custom CSS to other areas of theme.json * Remove typography setting as it needs to be done via CSS * Do the same for the variations * Fix notice style getting broken for css parsing issue --------- Co-authored-by: Imran Hossain <[email protected]> * Bump versions and update change log --------- Co-authored-by: Imran Hossain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
course_theme_variation_loaded, description is added below.Added hook
course_theme_variation_loaded- Fires after the variation is determined, can be used for different use cases, including loading variation specific stylesheetsDetails in this PR Automattic/sensei#7225