Authentication: Addressing Debt #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
changed the title
jleandroperez
commented
Jul 26, 2024
| @@ -52,6 +52,5 @@ | |||
| - (void)presentPasswordResetAlert; | |||
| - (void)presentPasswordCompromisedAlert; | |||
| - (void)presentUnverifiedEmailAlert; | |||
| - (void)showAuthenticationErrorForCode:(NSInteger)responseCode responseString:(NSString *)responseString; | |||
There was a problem hiding this comment.
This was triggering a warning. I've missed dropping the forward declaration, when ported to Swift
jleandroperez
commented
Jul 26, 2024
| } | ||
|
|
||
| authWindowController.switchToMagicLinkRequestedUI(email: email) | ||
| } |
There was a problem hiding this comment.
Not in use any longer!
jleandroperez
commented
Jul 26, 2024
| case passwordField: | ||
| state.password = passwordField.stringValue | ||
| state.password = passwordField.stringValue.trimmingCharacters(in: .whitespacesAndNewlines) |
There was a problem hiding this comment.
Legacy usernameText and passwordText had this trimming (L97 + L102 in this PR)
jleandroperez
commented
Jul 26, 2024
| @IBAction | ||
| func switchToPasswordAuth(_ sender: Any) { | ||
| mode = AuthenticationMode.loginWithPassword | ||
| } |
There was a problem hiding this comment.
This one wasn't in use
jleandroperez
commented
Jul 26, 2024
| } | ||
|
|
||
| var authWindowController: AuthWindowController? { | ||
| view.window?.windowController as? AuthWindowController | ||
| } |
3 tasks
charliescheer
approved these changes
Jul 26, 2024
|
TY!! 🔥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR we're addressing pending tech debt, in the AuthenticationViewController class.
Test
Please smoke test Auth with Password + Code, and verify everything looks great!!
Release