Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge release/4.55 into trunk #1685

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Merge release/4.55 into trunk #1685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9965cad
Fix label name for upload metadata step
mokagio Nov 2, 2024
17ff370
Remove `skip_confirm` parameter from update metadata lane call
mokagio Nov 2, 2024
9f238aa
Fix upload metadata lane call in CI (#1682)
mokagio Nov 2, 2024
ee530cd
Restore `skip_confirm` parameter for ASC metadata and wire with `force`
mokagio Nov 2, 2024
a929fb1
Allow bypassing confirmation in upload metadata via CI (#1683)
mokagio Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/release-pipelines/update-metadata-on-app-store-connect.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
IMAGE_ID: $IMAGE_ID

steps:
- label: Finalize Release
- label: Update Release Notes and Other Metadata on App Store Connect
plugins: [$CI_TOOLKIT_PLUGIN]
command: |
echo '--- :robot_face: Use bot for Git operations'
Expand Down
5 changes: 3 additions & 2 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ platform :ios do
# @option [Boolean] with_screenshots (default: false) If true, will also upload the latest screenshot files to ASC
#
desc 'Upload the localized metadata to App Store Connect, optionally including screenshots.'
lane :update_metadata_on_app_store_connect do |with_screenshots: false|
lane :update_metadata_on_app_store_connect do |skip_confirm: false, with_screenshots: false|
# Skip screenshots by default. The naming is "with" to make it clear that
# callers need to opt-in to adding screenshots. The naming of the deliver
# (upload_to_app_store) parameter, on the other hand, uses the skip verb.
Expand All @@ -99,7 +99,8 @@ platform :ios do
overwrite_screenshots: true, # won't have effect if `skip_screenshots` is true
phased_release: true,
precheck_include_in_app_purchases: false,
api_key_path: APP_STORE_CONNECT_KEY_PATH
api_key_path: APP_STORE_CONNECT_KEY_PATH,
force: skip_confirm
)
end

Expand Down