Run buildkite_pipeline_upload on branch HEAD
#1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mokagio
commented
Oct 30, 2024
| # not the commit that triggered the automation that eventaully called this. | ||
| # | ||
| # Useful during release automation builds that make additional commits to the release branch. | ||
| { **environment, BUILDKITE_COMMIT: last_git_commit[:commit_hash] } |
There was a problem hiding this comment.
Not the most elegant solution... One alternative could be to force the release script to checkout release branch, but that seem like limiting the script?
mokagio
added
tooling
mokagio
deleted the
mokagio/checkout-latest-release-branch-in-beta-build
branch
|
| App Name |  Simplenote Prototype Build |
|
| Build Number | pr1673-ee9b7d9-0192db3c-f00a-4239-a240-742a910e6ed8 | |
| Version | 4.55 | |
| Bundle ID | com.codality.NotationalFlow.Alpha | |
| Commit | ee9b7d9 | |
| App Center Build | Simplenote - Installable Builds #398 |
|
The build I triggered to test this was green, but it was a false positive 😞 The upload to TestFlight succeeded but that's because it uploaded version 4.55.0.1 which originally failed. What it should have uploaded was 4.55.0.2 The logs show the
But when the uploaded steps run, the commit the have in their environment is the original one: 
I guess we have to force checkout the latest release branch from the script after all. |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.
This is an attempt to solve the failure seen in https://buildkite.com/automattic/simplenote-ios/builds/1194 where the injected beta build steps run on the commit that triggered the injecting build, not the commit in which the codebase was when the steps were injected.