Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced automattic tracks cocoa pod with automattic track SPM #1549

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented Jan 16, 2024

Fix

Simplenote iOS is currently using tracks version 0.13, which is a little old... Tracks stopped supporting cocoa pods on version 2 as well. So it seemed like a good idea to update to using the SPM version of tracks and get onto the newest release. In this PR I have done that.

Relies on #1545

Test

(Required) List the steps to test the behavior. For example:

  1. pull the branch and run rake dependencies on the repo to update the pods
  2. make sure the app can build
  3. Trigger a trackable event (like opening the sidebar or making a note)
  4. Go to tracks live, wait a while, and then confirm your event comes through. Be aware that you can't filter SN events by user id, so you will have to find it manually

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

@charliescheer charliescheer self-assigned this Jan 16, 2024
@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label Jan 16, 2024
@charliescheer charliescheer marked this pull request as ready for review January 16, 2024 22:46
@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1549-48b47a0-018d1471-8bc8-470d-8b05-5a728e65db95 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@peril-automattic
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I LOVE this PR!!!

:shipit: sir!!

Base automatically changed from charlie/fix-rake-file to trunk January 17, 2024 21:27
@charliescheer
Copy link
Contributor Author

Merging this even though the UI Tests are failing. Will look into those in a future PR

@charliescheer charliescheer merged commit 97efa9b into trunk Jan 17, 2024
6 of 8 checks passed
@charliescheer charliescheer deleted the charlie/1543/upgrade-tracks-to-spm branch January 17, 2024 21:28
@charliescheer charliescheer linked an issue Jan 17, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update use of Automattic Tracks iOS to SPM
3 participants