[UI Tests] Handle "Save Password" prompt from iOS. #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can test the changes in simplenote-ios from this Pull Request by:
|
pachlava
commented
Nov 2, 2023
| @@ -3,7 +3,10 @@ import XCTest | |||
| class EmailLogin { | |||
|
|
|||
| class func open() { | |||
| app.buttons[UID.Button.logIn].waitForIsHittable() | |||
There was a problem hiding this comment.
In some cases, the test might try to tap Log In button while the Save password prompt is still being removed from the screen after tapping No (on this picture, Login button is covered by the prompt):
Waiting for the button to become hittable solves the issue.
pachlava
commented
Nov 2, 2023
Comment on lines
+44
to
+45
| "revision" : "5179cb69d58b90761cc713bdee7740c4889d3295", | ||
| "version" : "0.4.0" |
There was a problem hiding this comment.
Just updating XCUITestHelpers to the latest version.
crazytonyli
approved these changes
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
The UI tests weren't executed for a really long time, during which the
Save passwordprompt was introduced in iOS:The prompt blocked nearly all the tests. This PR adds handling of this prompt (always tapping
No).Test