Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct return types for update() calls #336

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Correct return types for update() calls #336

merged 1 commit into from
Apr 6, 2021

Conversation

joewestcott
Copy link
Contributor

Follows on from conversation in #334

mathieudutour
mathieudutour approved these changes Apr 6, 2021
View reviewed changes
Copy link
Collaborator

@mathieudutour mathieudutour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mathieudutour mathieudutour merged commit 9ca9150 into Automattic:master Apr 6, 2021
@joewestcott joewestcott deleted the fix-ts-update-defs branch April 11, 2021 13:17
@joewestcott
Copy link
Contributor Author

Could we have a release with this fix please @mathieudutour?

Then issues 326 & 334 can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieudutour mathieudutour mathieudutour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joewestcott @mathieudutour