Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: correct schema type inference when using nested typeKey like type: { type: String } #14956

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14950

Summary

#14950 points out that it is tricky to handle GeoJSON with TypeScript schema definitions because inferschematype doesn't handle type: { type: String } correctly.

Examples

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Oct 12, 2024
@vkarpov15 vkarpov15 added this to the 8.7.2 milestone Oct 14, 2024
@vkarpov15 vkarpov15 merged commit 0752c5d into master Oct 14, 2024
5 checks passed
@hasezoey hasezoey deleted the vkarpov15/gh-14950 branch October 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using typeKey and required throws a TypeError: Invalid schema configuration
2 participants