Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix vulnerability in example in redis todoRouter #11786

Merged
merged 3 commits into from
May 11, 2022
Merged

fix vulnerability in example in redis todoRouter #11786

merged 3 commits into from
May 11, 2022

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

@IslandRhythms IslandRhythms self-assigned this May 9, 2022
@IslandRhythms IslandRhythms linked an issue May 9, 2022 that may be closed by this pull request
Possible NoSQL injection due to lack of data sanitization in Redis-Todo example #11727
Closed
@IslandRhythms
Copy link
Collaborator Author

Very strange, getting a connection refused from redis.

AbdelrahmanHafez
AbdelrahmanHafez approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@AbdelrahmanHafez
Copy link
Collaborator

@IslandRhythms
What do you think of using ioredis in our examples?

When I needed to use redis with node, I found that ioredis (at the time) had much better capabilities with better promises support.

@vkarpov15
Copy link
Collaborator

@AbdelrahmanHafez I've never used ioredis, but I don't use redis much :) Right now regular redis seems to support async/await just fine, so I don't think it's worth changing.

@vkarpov15 vkarpov15 merged commit c8cf05d into master May 11, 2022
@vkarpov15 vkarpov15 deleted the gh-11727 branch May 11, 2022 20:10
@vkarpov15 vkarpov15 added this to the 6.3.4 milestone May 11, 2022
@vkarpov15 vkarpov15 added the docs This issue is due to a mistake or omission in the mongoosejs.com documentation label May 11, 2022
@AbdelrahmanHafez
Copy link
Collaborator

@vkarpov15
If node-redis support async/await, I agree that it's not worth changing. 👍
Glad that people are jumping on the async/await bandwagon, I assumed node-redis team was planning to take the passport stance because node-redis only supported that recently, I remember doing that search sometime in 2021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees

@IslandRhythms IslandRhythms

Labels
docs This issue is due to a mistake or omission in the mongoosejs.com documentation
Projects
None yet
Milestone
6.3.4
Development

Successfully merging this pull request may close these issues.

Possible NoSQL injection due to lack of data sanitization in Redis-Todo example
3 participants
@IslandRhythms @AbdelrahmanHafez @vkarpov15