Menschified juice #220
Merged
Menschified juice #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step for Automattic#215 , just changed 1 testcase and altered test comparison to consider multiple newlines as one newline.
…ort properties" Fixes Automattic#217 - Added simple test case
Fixes Automattic#218 . Added test-case and fixed expected output for integration test case (even if we fix order it is semantically identically so it is ok updating the expected result)
Test case for Automattic#216 This is fixed by moving from cssom to mensch as per Automattic#215
Test case for Automattic#74 . Mensch correctly deals with the filter property syntax.
This prove that mensch correctly parses the problematic CSS (Automattic#44)
Fixes Automattic#219 - Add test cases.
This reverts commit 8fe41ca.
| - "0.12" | ||
| - "0.11" | ||
| - "iojs" |
There was a problem hiding this comment.
Probably fine to take out iojs and 0.11 at least
|
A few nits we can work out here, but overall looks good to me. Great to see some of those stubborn issues fixed without modifying anything of note in the existing tests. |
|
Just tell me if you prefer me to keep working in my fork or if you prefer me to fix the minor changes you suggest in this comments and merge this PR before I make it "too big". |
|
I'm understanding you'll be making more changes so I won't bother with a release right now. Thanks for doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release replaces CSSOM with mensch and tries to mimic as much as possible the previous behaviours.
This fixes a bunch of issues (both CSSOM related and Juice core issues), see #215 for details. I referenced them in the single commits.
Hope this can be merged.
Now my next steps are: