Boost: make Concatenate modules work more consistently #40224
+152
−112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSS and JS Concatenate modules do not work in the same way other modules on the settings page work. This PR update them to fix that.
Instead of a cancel button, it uses the same show hide link other modules use, with up/down chevrons. I think I'd rather leave the text of the link, instead of changing it to "Hide" as the cursor has to be moved if it was not in the right place.
If the text input form is closed, the value of the form is reset to the saved value now. It would retain an edited version before, unlike other modules.
Fixes #36274
Proposed changes:
isExpanded
state like other modules now.inputLabel
parameter fromMetaComponent
as it usesdatasyncKey
to decide if JS or CSS.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: