Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreatModal: Add user connection gate #40204

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Nov 15, 2024

Description

Adds a connection gate to the ThreatModal

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Review Storybook entries for ThreatModal

Screenshots

Screen Shot 2024-11-18 at 14 02 58

@dkmyta dkmyta self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/components/threat-details-modal-user-connection-gate branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/components/threat-details-modal-user-connection-gate
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/components/threat-details-modal-user-connection-gate
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/js-packages/components

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@dkmyta dkmyta changed the title ThreatDetailsModal: Add user connection gate ThreatModal: Add user connection gate Nov 18, 2024
@dkmyta dkmyta marked this pull request as ready for review November 18, 2024 22:04
);
}

return <>{ children }</>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return <>{ children }</>;
return children;

Double nit - Can just return children, this could also be done as an early return at the top (personal preference).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 113862a

Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

* Add credentials gate

* Fix stories

* Fix credentials type

* Fix build issues, and add early returns for gates
@dkmyta dkmyta merged commit 5a2cac3 into add/components/threat-details-modal Nov 19, 2024
67 of 68 checks passed
@dkmyta dkmyta deleted the add/components/threat-details-modal-user-connection-gate branch November 19, 2024 18:12
dkmyta added a commit that referenced this pull request Nov 19, 2024
* Add ThreatDetailsModal component and stories

* changelog

* Fix type error

* Fix child component overflow-x styling

* Update scan package changelog

* Add util for fixerState and separate subcomponents

* Generalize component name

* Updates after renaming

* Ensure close button exists for vulns modal

* Fixes and improvements

* ThreatModal: Add user connection gate (#40204)

* Add user connection gate

* Fix stories

* ThreatModal: Add credentials gate (#40205)

* Add credentials gate

* Fix stories

* Fix credentials type

* Fix build issues, and add early returns for gates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants