-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Rewrite test command #40175
cli: Rewrite test command #40175
Conversation
Bring in a few new features: * Ability to specify multiple projects to test, which will be run in parallel if `--verbose` is not used. * Correct handling of tests that use `ARTIFACTS_DIR`. * Correct handling of coverage tests, without having to manually set `COVERAGE_DIR`. * Coverage tests now generate an HTML report by default. Unfortunately, there are some breaking changes here: * The order of the "test" and "project" arguments has changed. * By default the output from PHPUnit or jest will no longer be shown. Run with `--verbose` if you want to see it.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a few hiccups from my end, this seems to run as expected:
The following runs were successful:
- Standard run:
jetpack test coverage packages/codesniffer
- Parallel run:
jetpack test coverage packages/codesniffer packages/autoloader
- Custom HTML dir:
jetpack test coverage packages/codesniffer --html-dir=random_dir
- Custom Artifacts dir:
jetpack test coverage plugins/crm --artifacts-dir=random_dir
Proposed changes:
Bring in a few new features:
--verbose
is not used.ARTIFACTS_DIR
.COVERAGE_DIR
.Unfortunately, there are some breaking changes here:
--verbose
if you want to see it.Other information:
Jetpack product discussion
None to link. In our last Garage meeting we talked about having a way to run coverage tests locally to generate an HTML report, this is what I came up with.
Does this pull request change what data or activity we track or use?
No
Testing instructions: