Deprecation notices: Allow functionality to be used, and update styles #39567
+241
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/vulcan/issues/511
Fixes https://github.com/Automattic/jetpack-roadmap/issues/1812
Work-in-progress
Still to do:
Other possible changes needed depending on design suggestions:
Proposed changes:
Other information:
Jetpack product discussion
See p1HpG7-uu9-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
To test this out, you will need to add in a new notice in a couple of places. This will all be documented in a post once this PR is completed and merged.
$this->notices
example content in the__construct
function inclass-deprecate.php
.has_notices
function:/jetpack/_inc/client/components/jetpack-notices/index.jsx
addmy-admin-deprecate-features
intoconst noticeKeys
.notices
const within the render function (but change the two occurrences ofmy-xyz-removal-notice
withmy-admin-deprecate-features
. Change theshow
value to betrue && ! this.isNoticeDismissed( 'my-admin-deprecate-features' ),
Once the code is added, apply this PR locally, and make sure to build Jetpack and the My Jetpack package. Then, test the following areas: